Lint and Format Code
Thunderbird's source code is linted and formatted using automated tools, which provides several benefits that include:
ensuring a consistent formatting style across the code base
preventing formatting issues from taking up developer time in code review
catching problems that might otherwise go unnoticed
making it easier for developers to write well-formatted code
For JavaScript code we use both:
These tools can be used via the command line or right in your code editor.
After editing some JavaScript code, navigate to the comm/ directory. (The following commands need to be run from the comm/ directory so that Prettier will use the comm/.prettierignore file, and not the .prettierignore file in the directory just above comm/. See Prettier issue 4081.)
For a single file, run this command, which will attempt to automatically fix any linting or formatting problems:
$ ../mach lint path/to/a/file.js --fix
Or for all the files in a given directory:
$ ../mach lint path/to/a/directory/ --fix
To simply report any problems but not attempt to automatically fix them, just omit the --fix flag:
$ ../mach lint path/to/a/file.js
Most popular code editors offer plugins for eslint and Prettier. We highly recommend installing a plugin for eslint and a plugin for Prettier so you can lint and format your code as you are editing it. Issues will be highlighted as you type and you can have Prettier format your code with a few key strokes.
Here are links to plugins for various editors:
eslint plugins for various editors
Prettier plugins for various editors
Some of us on the Thunderbird team use the VS Code editor with these plugins:
VS Code plugin by Esben Petersen
ESLint
VS Code plugin by Dirk Baeumer
Mercurial has hooks that could be used to automatically check for linting and formatting issues, say when you make a commit.
Note that we do not currently have this set up for the Thunderbird code base. Initial attempts to use these hooks (as they are used for Firefox code) have not succeeded.
